[
https://issues.apache.org/jira/browse/BOOKKEEPER-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13649799#comment-13649799
]
Ivan Kelly commented on BOOKKEEPER-562:
---------------------------------------
Patch looks good. +1. There's no need for ledgerId as part of callback. It can
be passed in a number of other ways.
One last thing (you can do it when you push in the patch), is that the javadoc
shouldn't describe how the operation occurs, but rather what is does.
{code}
/**
* Read the ledger metadata for lId and return true if the
* ledger has been closed asynchronously.
{code}
would be better as
{code}
/**
* Check whether ledger, identified by <i>lId</i>, is closed.
* This is an asynchronous call.
{code}
Also, the sync version should say the same (except) for the async part. The
description isn't long enough to warrant a redirection.
> Ability to tell if a ledger is closed or not
> --------------------------------------------
>
> Key: BOOKKEEPER-562
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-562
> Project: Bookkeeper
> Issue Type: New Feature
> Reporter: Whitney Sorenson
> Assignee: Flavio Junqueira
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-562-1.patch, BOOKKEEPER-562.patch,
> BOOKKEEPER-562.patch, BOOKKEEPER-562.patch, BOOKKEEPER-562.patch,
> BOOKKEEPER-562.patch
>
>
> We need to be able to differentiate between open and closed ledgers, because
> we want to persist ledgers which are closed and wait for ledgers that are
> open to close.
> There doesn't seem to be an easy way to get a list of closed / open ledgers
> or to query bk to ask if a specific ledger is open or closed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
