[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13698459#comment-13698459
 ] 

Sijie Guo edited comment on BOOKKEEPER-629 at 7/3/13 12:48 AM:
---------------------------------------------------------------

{quote}
So if I understand correctly, here the idea is to keep the identifier as 
'hostname:port' format. For example, one bookie starts with the id 
'HOST-10-18-40-30:8020', when user change the hostname to 'HOST-10-18-40-35', 
this bookie will publish 'HOST-10-18-40-30:8020' and content as the actual 
'HOST-10-18-40-35:8020'. Here I could see one conflicts, say when a new bookie 
wants to joins with its actual hostname as 'HOST-10-18-40-30' and port 8020, he 
will get ZNodeExistsException.
{quote}

unless you had a global id assignment, you had resolved this issue in uuid case.

for me, this solution is making confused about the identifier, you had no idea 
about it is an old version bookie or a new version bookie. actually I don't 
like the proposal I raised.

so if there is no clear solution for backward compatibility, I would suggest 
keeping current identifier format and providing an admin tool to change 
identifier. Let's do the generic solution util there is a big requirement and 
have to do it. for now keep things simple. 





                
      was (Author: hustlmsp):
    {quote}
So if I understand correctly, here the idea is to keep the identifier as 
'hostname:port' format. For example, one bookie starts with the id 
'HOST-10-18-40-30:8020', when user change the hostname to 'HOST-10-18-40-35', 
this bookie will publish 'HOST-10-18-40-30:8020' and content as the actual 
'HOST-10-18-40-35:8020'. Here I could see one conflicts, say when a new bookie 
wants to joins with its actual hostname as 'HOST-10-18-40-30' and port 8020, he 
will get ZNodeExistsException.
{quote}

unless you had a global id assignment, you had resolved this issue in uuid case.

for me, this solution is making confused about the identifier, you had no idea 
about it is an old version bookie or a new version bookie. actually I don't 
like the proposal I raised.

so if there is no clear solution for backward compatibility, I would suggest 
keeping current identifier format and providing an admin tool to change 
identifier. Let's do the generic solution util there is a big requirement and 
have to do it. keep things simple. 





                  
> Support hostname based ledger metadata to help users to change IP with 
> exitsting installation
> ---------------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-629
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-629
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery, bookkeeper-client, 
> bookkeeper-server
>    Affects Versions: 4.2.1, 4.3.0
>            Reporter: Vinay
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 1-BOOKKEEPER-629.patch, 2-BOOKKEEPER-629.patch, 
> 3-BOOKKEEPER-629.patch, 4-BOOKKEEPER-629.patch, 5-BOOKKEEPER-629.patch, 
> 6-BOOKKEEPER-629.patch
>
>
> Register the bookie with *hostname:port* and also store the bookie addresses 
> as *hostname:port* in ledger metadata files instead of *ip:port*
> This will help users to change the machine IP if they want without loosing 
> their data.
> Supporting hostname based installation/functionality is one of the important 
> requirement of users.
> Any thoughts?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to