[
https://issues.apache.org/jira/browse/BOOKKEEPER-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713738#comment-13713738
]
Ivan Kelly commented on BOOKKEEPER-429:
---------------------------------------
Patch looks good. There's a few things that need to be fixed before submission
though.
# MultipleThreadReadTest.java needs a license, it should probably be in the
proto package as it's testing functionality there.
# RequestProcessor.java should be in proto package also. It deals with RPC
stuff.
# The executors should be created with a thread factory so that the worker
threads have meaningful names.
# I don't think we should allow 0 worker threads to be configured. It only
exists for one test. It'd be better to fix the test.
Sorry for taking so long to get to these. I've had a very busy couple of weeks.
> Provide separate read and write threads in the bookkeeper server
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-429
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-429
> Project: Bookkeeper
> Issue Type: Improvement
> Components: bookkeeper-server
> Affects Versions: 4.2.0
> Reporter: Aniruddha
> Assignee: Aniruddha
> Fix For: 4.3.0
>
> Attachments: BK-429.patch, BOOKKEEPER-429.diff
>
>
> The current bookkeeper server is single threaded. The same thread handles
> reads and writes. When reads are slow (possibly because of excessive seeks),
> add entry operations suffer in terms of latencies. Providing separate read
> and write threads helps in reducing add entry latencies and increasing
> throughput even when we're facing slow reads. Having a single read thread
> also results in low disk utilization because seeks can't be ordered
> efficiently by the OS. Multiple read threads would help in improving the read
> throughput.
> Discussion on this can be found at
> http://mail-archives.apache.org/mod_mbox/zookeeper-bookkeeper-dev/201209.mbox/%3ccaolhydqpzn-v10zynfwud_h0qzrxtmjgttx7a9eofohyyty...@mail.gmail.com%3e
> Reviewboard : https://reviews.apache.org/r/7560/
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
