[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718026#comment-13718026
 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-604:
------------------------------------------------

Nits:
{code}
    try {
                            ledgerCache.putEntryOffset((long)id, 1, 0);
                            } catch (Bookie.NoLedgerException nle) {
                                //ignore
                            }
{code}
format is off here.
I think AtomicLong unused here. remove import.

                
> Ledger storage can log an exception if GC happens concurrently.
> ---------------------------------------------------------------
>
>                 Key: BOOKKEEPER-604
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-604
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.2, 4.3.0
>
>         Attachments: 
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, 
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, 
> 0001-BOOKKEEPER-604-Ledger-storage-can-log-an-exception-i.patch, 
> BOOKKEEPER-604.diff
>
>
> If a ledger is flushing, and part way through,GC kicks in, it can delete the 
> index file before we try and flush it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to