[ https://issues.apache.org/jira/browse/BOOKKEEPER-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13718424#comment-13718424 ]
Vinay commented on BOOKKEEPER-632: ---------------------------------- {quote}he patch adds a new public api to read the readonly bookies, then manually reads them in Auditor#getAvailableBookies(). It would be much better if this method read the bookies through BookKeeperAdmin's apis, so that if we change the format in future, we have less places to update.{quote} I agree with your point Ivan, But the ways bookie addresses handled in Auditor and ReplicationWorker are different. In Auditor, bookie address is treated as just string, where as in RW its InetSocketAddress. BookKeeperAdmin#getReadOnlyBookie() will return collection of InetSocketAdress. So changes for this will be more and IMO that is out of scope of this Jira. Any thoughts..? > AutoRecovery should consider read only bookies > ---------------------------------------------- > > Key: BOOKKEEPER-632 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-632 > Project: Bookkeeper > Issue Type: Bug > Components: bookkeeper-auto-recovery, bookkeeper-server > Affects Versions: 4.2.1, 4.3.0 > Reporter: Vinay > Assignee: Vinay > Fix For: 4.2.2, 4.3.0 > > Attachments: BOOKKEEPER-632.patch, BOOKKEEPER-632.patch, > BOOKKEEPER-632.patch > > > Autorecovery Auditor should consider the readonly bookies as Available > Bookies while publishing the under-replicated ledgers. > Also AutoRecoveryDaemon should shutdown if the local bookie is readonly -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira