[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13728986#comment-13728986
 ] 

Sijie Guo commented on BOOKKEEPER-666:
--------------------------------------

why set everything to daemon? when JVM halts, any remaining daemon threads are 
abandoned: finally blocks not executed, stacks are not unwound. JVM just exits. 
its is really bad for most cases, especially for I/O.

when you just want to add names for threads, then just add names, don't change 
the behavior.
                
> Naming threads of ExecutorService
> ---------------------------------
>
>                 Key: BOOKKEEPER-666
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-666
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-client, bookkeeper-server, hedwig-client, 
> hedwig-server
>    Affects Versions: 4.2.1
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 4.3.0
>
>         Attachments: 0001-BOOKKEEPER-666.patch
>
>
> Useful to provide the naming behavior. Otw executors would create threads 
> with default name like 'Thread[pool-1-thread-1]'.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to