[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751478#comment-13751478
 ] 

Sijie Guo commented on BOOKKEEPER-494:
--------------------------------------

I had a different approach (will generate the patch) than the way that Vinay 
did. I don't think it is a good idea to override everything without comparing 
the old cookie and the new cookie. adding a new directory and replacing a 
directory should be explicitly specified on the admin command not just 
generating the cookie from configuration, since it is the critical metadata for 
a bookie instance. and also during modifying the cookies, we should not 
override the old cookie file, otherwise we don't have any chance to rollback 
and also for consistency checking.
                
> Ability to add new ledger disk to a bookie
> ------------------------------------------
>
>                 Key: BOOKKEEPER-494
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-494
>             Project: Bookkeeper
>          Issue Type: New Feature
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Vinay
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-494.diff
>
>
> Currently we had *Cookie* for each bookie to record the directories it used 
> for ledgers. So when the admin wants to add a new disk for a bookie, we can't 
> change the configuration and restart it simply. an admin command would be 
> added to help admin guys adding a new disk to a bookie and upgrading its 
> *Cookie*.
> Adding a brand new disk would be quite easy. But if we want to remove a disk 
> or replace a disk, it isn't trivial. BOOKKEEPER-201 would take care of 
> removing/replace a disk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to