The oom issue isn't a blocker (the problem is zk's oververbose logging). BOOKKEEPER-683 is though.
I agree we should cancel this rc. However, it will probably be october before I can cut a new one. Busy couple of weeks coming up. -Ivan On Thu, Sep 12, 2013 at 09:35:39PM +0100, Flavio Junqueira wrote: > I'm getting the same problem with GcLedgersTest: > > Exception in thread "ThreadedStreamConsumer" java.lang.OutOfMemoryError: Java > heap space > at java.util.Arrays.copyOf(Arrays.java:2367) > at > java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java:130) > at > java.lang.AbstractStringBuilder.ensureCapacityInternal(AbstractStringBuilder.java:114) > at > java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:415) > at java.lang.StringBuffer.append(StringBuffer.java:237) > at > org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMessage(ConsoleOutputFileReporter.java:115) > at > org.apache.maven.surefire.report.MulticastingReporter.writeMessage(MulticastingReporter.java:101) > at > org.apache.maven.surefire.report.TestSetRunListener.writeTestOutput(TestSetRunListener.java:99) > at > org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:132) > at > org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67) > at java.lang.Thread.run(Thread.java:722) > > and one test failure on hedwig-server (BOOKKEEPER-683). I don't want to be a > party pooper, but I'd feel more comfortable if we could fix these issues and > have another release candidate. What do you think? > > -Flavio > > > On Sep 12, 2013, at 3:27 PM, Jiannan Wang <jian...@yahoo-inc.com> wrote: > > > Agree, thanks for the finding. > > > > Best, > > Jiannan > > > > On 9/12/13 6:05 PM, "Ivan Kelly" <iv...@apache.org> wrote: > > > >> I managed to repro with > >> MAVEN_OPTS="-Xmx128M" mvn test -Dtest=GcLedgersTest > >> > >> The test in question creates 30000 ledgers, using asyncCreateLedgers, > >> which causes a lot of zk INFO level log messages. > >> > >> This isn't an issue worth blocking the release for. > >> > >> -Ivan > >> > >> On Thu, Sep 12, 2013 at 09:42:49AM +0000, Ivan Kelly wrote: > >>> Hi Jiannan, > >>> > >>> Could you send me the logs for this. The <argLine> in the pom has no > >>> affect here because that only applies to the surefire child > >>> process. This OOM is in the maven process itself, because the test is > >>> producing too many logs. I'll try reducing my heap to see if I can get > >>> the same to happen. > >>> > >>> -Ivan > >>> > >>> > >>> On Thu, Sep 12, 2013 at 03:31:19AM +0000, Jiannan Wang wrote: > >>>> +1 for this release. > >>>> > >>>> All test cases pass except org.apache.bookkeeper.meta.GcLedgersTest, > >>> which > >>>> throws following exception > >>>> ---------- > >>>> Exception in thread "ThreadedStreamConsumer" > >>> java.lang.OutOfMemoryError: > >>>> Java heap space > >>>> at java.util.Arrays.copyOf(Arrays.java:2882) > >>>> at > >>>> > >>> java.lang.AbstractStringBuilder.expandCapacity(AbstractStringBuilder.java > >>> :1 > >>>> 00) > >>>> at > >>> java.lang.AbstractStringBuilder.append(AbstractStringBuilder.java:390) > >>>> at java.lang.StringBuffer.append(StringBuffer.java:224) > >>>> at > >>>> > >>> org.apache.maven.surefire.report.ConsoleOutputFileReporter.writeMessage(C > >>> on > >>>> soleOutputFileReporter.java:115) > >>>> at > >>>> > >>> org.apache.maven.surefire.report.MulticastingReporter.writeMessage(Multic > >>> as > >>>> tingReporter.java:101) > >>>> at > >>>> > >>> org.apache.maven.surefire.report.TestSetRunListener.writeTestOutput(TestS > >>> et > >>>> RunListener.java:99) > >>>> at > >>>> > >>> org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLi > >>> ne > >>>> (ForkClient.java:132) > >>>> at > >>>> > >>> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsum > >>> er > >>>> $Pumper.run(ThreadedStreamConsumer.java:67) > >>>> at java.lang.Thread.run(Thread.java:680) > >>>> ---------- > >>>> > >>>> I need to execute 'export MAVEN_OPTS="-Xmx1G"' before running the > >>> test. > >>>> (So the <argLine>-Xmx1G -Djava.net.preferIPv4Stack=true</argLine> in > >>>> pom.xml takes no effect? My maven version is Apache Maven 3.0.3 > >>> (r1075438; > >>>> 2011-03-01 01:31:09+0800)) > >>>> > >>>> It's not a problem for the release, but I think maybe we can reduce > >>>> annoying zk logs for this test to get around this problem. > >>>> > >>>> > >>>> Best, > >>>> Jiannan > >>>> > >>>> > >>>> > >>>> > >>>> On 9/11/13 6:52 AM, "Ivan Kelly" <iv...@apache.org> wrote: > >>>> > >>>>> This is the first release candidate for Apache Bookkeeper, version > >>>>> 4.2.2. > >>>>> > >>>>> This is a bugfix release for 4.2.1. There are some minor API > >>>>> improvements. Notably, it is now possible to check whether a ledger > >>> is > >>>>> closed without opening it, and it is now possible to get a list of > >>>>> ledgers available in the cluster. > >>>>> > >>>>> The full release notes is available at: > >>>>> > >>>> > >>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12324601& > >>>> st > >>>>> yleName=Text&projectId=12311293 > >>>>> > >>>>> *** Please download, test and vote by September 16th 2013, 10:00 > >>> UTC+0. > >>>>> *** > >>>>> > >>>>> Note that we are voting upon the source (tag), binaries are provided > >>> for > >>>>> convenience. > >>>>> > >>>>> Source and binary files: > >>>>> http://people.apache.org/~ivank/bookkeeper-4.2.2-candidate-0/ > >>>>> > >>>>> Maven staging repo: > >>>> > >>>> https://repository.apache.org/content/repositories/orgapachebookkeeper-0 > >>>> 25 > >>>>> / > >>>>> > >>>>> The tag to be voted upon: > >>>> > >>>> https://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.2.2 > >>>>> > >>>>> Bookkeeper's KEYS file containing PGP keys we use to sign the > >>> release: > >>>>> http://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS > >>>>> > >>>>> Please download the the source package, and follow the README to > >>> build > >>>>> and run a bookkeeper and hedwig service. > >>>>> > >>>>> -Ivan > >>>> > > >