[
https://issues.apache.org/jira/browse/BOOKKEEPER-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13860072#comment-13860072
]
Rakesh R commented on BOOKKEEPER-644:
-------------------------------------
Following are few example cases where the patch contains the changes(like
import/spaces etc) which ideally not required for this issue.
If we avoid these kind of changes, it would be easy for anyone to directly open
and review the changes. isn't it?. I noticed this becuase this patch is too big.
- BenchBookie.java. Here the followig are only for removing the imports of few
classes and add it again to some other lines.
{code}
-import org.jboss.netty.buffer.ChannelBuffer;
-import org.jboss.netty.buffer.ChannelBuffers;
-import org.jboss.netty.channel.socket.ClientSocketChannelFactory;
-import org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory;
-
+import org.jboss.netty.buffer.ChannelBuffer;
+import org.jboss.netty.buffer.ChannelBuffers;
+import org.jboss.netty.channel.socket.ClientSocketChannelFactory;
+import org.jboss.netty.channel.socket.nio.NioClientSocketChannelFactory;
{code}
- Bookie.java. Here the following changes are only for removing the unwanted
spaces.
{code}
- /**
+ /**
* Retrieve the ledger descriptor for the ledger which entry should be
added to.
- * The LedgerDescriptor returned from this method should be eventually
freed with
+ * The LedgerDescriptor returned from this method should be eventually
freed with
* #putHandle().
*
* @throws BookieException if masterKey does not match the master key of
the ledger
*/
- private LedgerDescriptor getLedgerForEntry(ByteBuffer entry, byte[]
masterKey)
+ private LedgerDescriptor getLedgerForEntry(ByteBuffer entry, byte[]
masterKey)
throws IOException, BookieException {
long ledgerId = entry.getLong();
LedgerDescriptor l = handles.getHandle(ledgerId, masterKey);
@@ -927,7 +926,7 @@ public class Bookie extends BookieCriticalThread {
}
/**
- * Add an entry to a ledger as specified by handle.
+ * Add an entry to a ledger as specified by handle.
*/
{code}
> Provide a bookie address wrapper
> --------------------------------
>
> Key: BOOKKEEPER-644
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-644
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-client, bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-644.diff, BOOKKEEPER-644.diff,
> BOOKKEEPER-644.diff, BOOKKEEPER-644.diff
>
>
> Provide bookie address wrapper for BOOKKEEPER-629, so client would use the
> address identifier by server w/o involving in deciding using ip or hostname.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
