[ https://issues.apache.org/jira/browse/BOOKKEEPER-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870879#comment-13870879 ]
Rakesh R commented on BOOKKEEPER-662: ------------------------------------- Nice work Sijie. Adding few comments, please see: # Please add "private static final long serialVersionUID = " to public static class DiskWarnThresholdException. # Please include log message showing the DiskWarnThreshold, so that will be helpful to do analysis. # CompactionTest.java has few compilation errors, due to LedgerDirsManager constructor changes. # Would like to see testcase checking DiskWarnThreshold exception. > Major GC should kick in immediately if remaining space reaches a warning > threshold > ---------------------------------------------------------------------------------- > > Key: BOOKKEEPER-662 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-662 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-server > Reporter: Sijie Guo > Assignee: Aniruddha > Fix For: 4.3.0 > > Attachments: 0001-WIP.patch, BOOKKEEPER-662.diff, BOOKKEEPER-662.diff > > > in a high throughput case, Major GC should kick in immediately if remaining > spaces reaches a warning threshold. -- This message was sent by Atlassian JIRA (v6.1.5#6160)