[
https://issues.apache.org/jira/browse/BOOKKEEPER-720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13877416#comment-13877416
]
Hadoop QA commented on BOOKKEEPER-720:
--------------------------------------
Testing JIRA BOOKKEEPER-720
Patch
[0001-BOOKKEEPER-720-CheckpointSource.MIN-compareTo-does-e.patch|https://issues.apache.org/jira/secure/attachment/12624107/0001-BOOKKEEPER-720-CheckpointSource.MIN-compareTo-does-e.patch]
downloaded at Tue Jan 21 11:30:55 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 891
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/564/
> CheckpointSource.MIN#compareTo does exactly the opposite of what it should
> --------------------------------------------------------------------------
>
> Key: BOOKKEEPER-720
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-720
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.3.0
>
> Attachments:
> 0001-BOOKKEEPER-720-CheckpointSource.MIN-compareTo-does-e.patch
>
>
> CheckpointSource.MIN#compareTo returns 1 which means that "this" is greater
> than the passed argument (see java.util.Comparable javadoc). It should return
> -1.
> This hasn't been a problem, because MIN isn't currently used anywhere.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
