[
https://issues.apache.org/jira/browse/BOOKKEEPER-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903794#comment-13903794
]
Rakesh R commented on BOOKKEEPER-730:
-------------------------------------
Nice idea and thanks for the patch [~ikelly].
Just few comments. Apart from these +1.
- wrong indent in pom.xml
{code}
+ <roots><root>.</root></roots>
{code}
- Can we revert the changes done in BOOKKEEPER-724 ?
> Shade pom file missing apache license header
> --------------------------------------------
>
> Key: BOOKKEEPER-730
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-730
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Sijie Guo
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.3.0, 4.2.3
>
> Attachments:
> 0001-BOOKKEEPER-730-Shade-pom-file-missing-apache-license.patch
>
>
> Shade plugin doesn't generate pom file with apache license header.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
