[
https://issues.apache.org/jira/browse/BOOKKEEPER-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13929969#comment-13929969
]
Sijie Guo commented on BOOKKEEPER-716:
--------------------------------------
for 1), i don't mind adding the flag. but I am not very sure if we really need
the flag. since in the past release we also bump journal version, which were
also breaking changes as you said. and more concerned that shall we need to do
each time we bump version on either disk format?
for 2), as the batching logic is in journal side, I would prefer adding the
padding logic in journal side, rather than journalchannel.
for 3), the padding there is just for easy to track if it is a padding or a
normal record. it doesn't affect any correctness or performance issue. you
could still let reads start from 512 boundary.
for 4) I could make sector size to be configurable.
> padding writes for bookie journal
> ---------------------------------
>
> Key: BOOKKEEPER-716
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-716
> Project: Bookkeeper
> Issue Type: Sub-task
> Components: bookkeeper-server
> Reporter: Sijie Guo
> Assignee: Sijie Guo
> Fix For: 4.3.0
>
> Attachments: BOOKKEEPER-716.diff, BOOKKEEPER-716_715.diff
>
>
> it would be better to pad journal writes to align sector size, which to avoid
> second syncing corrupt an already synced sector/page.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
