[
https://issues.apache.org/jira/browse/BOOKKEEPER-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992613#comment-13992613
]
Flavio Junqueira commented on BOOKKEEPER-747:
---------------------------------------------
The reason for synchronizing listenerSet in MSLedgerManagerFactory is that I'm
removing the listeners (and notifying) when the metadata is removed. The same
functionality doesn't seem to be present in the AbstractZK version, so I think
in the worst case we will be processing a slightly stale list if we don't
synchronize.
Given this context, there are two questions I'd like to ask:
# Should we have the "REMOVED" functionality in this patch given that we don't
have it in AbstractZK?
# What can go wrong if we don't synchronize listenerSet in AbstractZK?
> Implement register/unregister LedgerMetadataListener in MSLedgerManagerFactory
> ------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-747
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-747
> Project: Bookkeeper
> Issue Type: Improvement
> Affects Versions: 4.3.0, 4.2.3
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Fix For: 4.3.0, 4.2.3
>
> Attachments: BOOKKEEPER-747-4.2.patch, BOOKKEEPER-747-4.2.patch,
> BOOKKEEPER-747-4.2.patch, BOOKKEEPER-747.patch, BOOKKEEPER-747.patch,
> BOOKKEEPER-747.patch, BOOKKEEPER-747.patch, BOOKKEEPER-747.patch
>
>
> Check TODOs in MSLedgerManagerFactory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
