[ https://issues.apache.org/jira/browse/BOOKKEEPER-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995580#comment-13995580 ]
Hadoop QA commented on BOOKKEEPER-756: -------------------------------------- Testing JIRA BOOKKEEPER-756 Patch [BOOKKEEPER-756.diff|https://issues.apache.org/jira/secure/attachment/12644370/BOOKKEEPER-756.diff] downloaded at Mon May 12 19:47:24 UTC 2014 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:green}+1{color} the patch does adds/modifies 2 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:green}+1 TESTS{color} . Tests run: 916 {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:green}*+1 Overall result, good!, no -1s*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/634/ > Use HashedwheelTimer for request timeouts for PCBC > -------------------------------------------------- > > Key: BOOKKEEPER-756 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-756 > Project: Bookkeeper > Issue Type: Improvement > Components: bookkeeper-client > Reporter: Sijie Guo > Assignee: Sijie Guo > Fix For: 4.3.0, 4.2.3 > > Attachments: BOOKKEEPER-756.diff > > > Current scheduler based timeout mechanism is per batch, which isn't > efficient. HashedWheelTimer is much better for timeouts. So change the PCBC > to use HashedWheelTimer for timeouts. > Besides that HashedWheelTimer change, it also provides multiple channel per > bookie support for latency consideration. -- This message was sent by Atlassian JIRA (v6.2#6252)