[ https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100109#comment-14100109 ]
Sijie Guo commented on BOOKKEEPER-736: -------------------------------------- {quote} rereplicateOpStats.registerSuccessfulEvent(latencyMillis) {quote} rereplicate op stats already has a counter for the re-replication operations. {quote} If there are UrLedgers it gives hint that the BK cluster has to be carefully observed to see its successful recovery, because there are missing replicas and could be a concern for critical data like Namenode WAL {quote} as I said that, the counter dosn't provided any meaningful info on underreplicated ledgers. for example, bookie process starts up, it marks 3 ledgers as underreplicated, the counter is 3. bookie failed and restarted, the counter was reset to 0. those 3 ledgers are marked as replicated after re-replicated. so the counter becomes -3. what does -3 mean? it means nothing. if you strongly want to put those stats in, please provide the mechanism that could provide a meaningful stat for them. otherwise, we just end up arguing on meaningless things. > Stats for AutoRecovery > ---------------------- > > Key: BOOKKEEPER-736 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-736 > Project: Bookkeeper > Issue Type: New Feature > Components: bookkeeper-auto-recovery > Reporter: Rakesh R > Assignee: Sijie Guo > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-736.patch, BOOKKEEPER-736.v2.patch, > Prototype-JMX-beans-for-standalone-autorecovery-process.png > > > Idea of this JIRA is to provide jmx interfaces to get the statistics of the > auto recovery activities. -- This message was sent by Atlassian JIRA (v6.2#6252)