[ https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131436#comment-14131436 ]
Hadoop QA commented on BOOKKEEPER-782: -------------------------------------- Testing JIRA BOOKKEEPER-782 Patch [BOOKKEEPER-782.patch|https://issues.apache.org/jira/secure/attachment/12668282/BOOKKEEPER-782.patch] downloaded at Fri Sep 12 11:08:27 UTC 2014 ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 120 . {color:red}-1{color} the patch does not add/modify any testcase {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 23 Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1 FINDBUGS{color} . {color:green}+1{color} the patch does not seem to introduce new Findbugs warnings {color:red}-1 TESTS{color} . Tests run: 921 . Tests failed: 0 . Tests errors: 1 . The patch failed the following testcases: . {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/bookkeeper-trunk-precommit-build/724/ > Use builder pattern for Cookie > ------------------------------ > > Key: BOOKKEEPER-782 > URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782 > Project: Bookkeeper > Issue Type: Sub-task > Components: bookkeeper-server > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 4.3.0 > > Attachments: BOOKKEEPER-782.patch, BOOKKEEPER-782.patch > > > It would be good to use builder pattern for Cookie, rather than modifying the > fields in place. -- This message was sent by Atlassian JIRA (v6.3.4#6332)