> Your release script is actually attached in that email :) > But the link that you provided is yahoo internal link :) you might take care > of this next time, if it is yahoo confidential :)
Wow, I didn't notice that, thanks for pointing it out. I need to be more careful to avoid being fired :) > This is a very awesome script to run. I think we could add it to the repo > under bin/ directory. Do you mind creating a JIRA to do that? we could > include it in 4.3.1 and 4.4.0. Done, https://issues.apache.org/jira/browse/BOOKKEEPER-788. I'll create a patch tomorrow. > for the git tag question, I am not sure if we could do that, since the > bookkeeper repo is actually in svn rather than git. Maybe we could manage it manually in GitHub? Thanks, Jiannan From: Sijie Guo <guosi...@gmail.com<mailto:guosi...@gmail.com>> Date: Saturday, October 4, 2014 at 4:42 PM To: "Y.CORP.YAHOO.COM\\jiannan" <jian...@yahoo-inc.com<mailto:jian...@yahoo-inc.com>> Cc: "bookkeeper-dev@zookeeper.apache.org<mailto:bookkeeper-dev@zookeeper.apache.org>" <bookkeeper-dev@zookeeper.apache.org<mailto:bookkeeper-dev@zookeeper.apache.org>> Subject: Re: [VOTE] BookKeeper 4.3.0 Release Candidate 0 Thanks Jiannan! This is a very awesome script to run. I think we could add it to the repo under bin/ directory. Do you mind creating a JIRA to do that? we could include it in 4.3.1 and 4.4.0. for the git tag question, I am not sure if we could do that, since the bookkeeper repo is actually in svn rather than git. - Sijie On Fri, Oct 3, 2014 at 9:26 PM, Jiannan Wang <jian...@yahoo-inc.com<mailto:jian...@yahoo-inc.com>> wrote: Thanks Sijie. +1 for the tag, verified successfully in following platforms: * Mac OS X 10.9.4, JDK 1.7.0_45, Maven 3.0.5 * Red Hat Enterprise Linux Server release 5.4, JDK 1.6.0_13, Maven 3.0.4 * Red Hat Enterprise Linux Server release 6.5, JDK 1.7.0_60, Maven 3.2.1 By the way, it would be convenient if git tag could also be provided. During verification, I find we need to type several commands to validate each release, which would be boring. So I create a script to wrap up all steps, see attachment. Usage: place the script outside source code (to avoid rat check failure) and run it under the top-level directory. Here is process of the script: 1. Collecting build environment info (Operation System, JDK, Maven) 2. Run 'mvn install -DskipTests' 3. Checking code (findbugs, rat now). Should I add mvn javadoc:aggregate? 4. Running unit test 5. Start standalone Bookie and Hedwig service 6. Run simple Bookie test: bookkeeper-server/bin/bookkeeper simpletest -ensemble 3 -writeQuorum 3 7. Run simple Hedwig test: hedwig-server/bin/hedwig console; pubsub topic subscriber 10 message 8. Tar all above logs when error/exit Furthermore, with the tar logs we could diagnose user's compile/UT failure. Best, Jiannan On 10/3/14, 4:55 PM, "Sijie Guo" <guosi...@gmail.com<mailto:guosi...@gmail.com>> wrote: >This is the first release candidate for Apache BookKeeper, version 4.3.0. > >It fixes the following issues: >https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12323267&st >yleName=Html&projectId=12311293 > >*** Please download, test and vote by Oct 7th 2014, 00:00 GMT. > >Note that we are voting upon the source (tag), binaries are provided >for convenience. > >Source and binary files: >http://people.apache.org/~sijie/bookkeeper-4.3.0-candidate-0/ > >Maven staging repo: >https://repository.apache.org/content/repositories/orgapachebookkeeper-100 >2/ > >The tag to be voted upon: >http://svn.apache.org/repos/asf/zookeeper/bookkeeper/tags/release-4.3.0/ > >BookKeeper's KEYS file containing PGP keys we use to sign the release: >http://svn.apache.org/repos/asf/zookeeper/bookkeeper/dist/KEYS > >Please download the the source package, and follow the README to build >and run a bookkeeper and hedwig service.
