[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204954#comment-14204954
 ] 

Ivan Kelly commented on BOOKKEEPER-796:
---------------------------------------

Patch has two parts. Firstly, it hooks ZookeeperClient into the bookkeeper 
client. This is all very straightforward.

Secondly, I added a thread in BookKeeperClusterTestCase, which kills the 
clients zookeeper session every 1 second. Tests run with this, and mostly pass, 
but there's some flakiness. All tests should succeed with this, but I think 
these are different fixes. One thing that is broken is that #close fails if it 
gets a MetadataVersionException. This is wrong. It should only fail if 
assumptions have changed. I think BOOKKEEPER-795 should fix this. Other tests 
fail because timeouts are too short, afaics. Having to retry metadata 
operations takes more time.

> Make bookkeeper client use reconnectable zookeeper wrapper
> ----------------------------------------------------------
>
>                 Key: BOOKKEEPER-796
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-796
>             Project: Bookkeeper
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.4.0
>
>         Attachments: 
> 0001-BOOKKEEPER-796-Make-bookkeeper-client-use-reconnecta.patch
>
>
> BOOKKEEPER-704 introduced a reconnectable zookeeper wrapper. This patch is to 
> make the bookkeeper client use it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to