[
https://issues.apache.org/jira/browse/BOOKKEEPER-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14221652#comment-14221652
]
Hadoop QA commented on BOOKKEEPER-800:
--------------------------------------
Testing JIRA BOOKKEEPER-800
Patch
[0001-Expose-whether-a-ledger-has-been-closed.patch|https://issues.apache.org/jira/secure/attachment/12682903/0001-Expose-whether-a-ledger-has-been-closed.patch]
downloaded at Sat Nov 22 00:06:02 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
. Tests run: 930
. Tests failed: 1
. Tests errors: 0
. The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/837/
> Expose whether a ledger is closed or not
> ----------------------------------------
>
> Key: BOOKKEEPER-800
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-800
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Fix For: 4.4.0, 4.3.1, 4.2.4
>
> Attachments: 0001-Expose-whether-a-ledger-has-been-closed.patch,
> 0001-Expose-whether-a-ledger-has-been-closed.patch
>
>
> On issue i could writing the tutorial is that when you open a ledger in
> non-recovery mode, it's not possible to check if the ledger you opened has
> been closed or is still been written too. This complicates things when you
> get to the end of the ledger, as you don't know whether to try for more
> entries in the same ledger, or to look at the next ledger is the list.
> This jira is to expose this information (it's in the metadata). This method
> only makes sense for reading. For writing a ledger, you really should know if
> you closed the ledger or not, and if you don't then you shouldn't be touching
> it again.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
