[
https://issues.apache.org/jira/browse/BOOKKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223216#comment-14223216
]
Hadoop QA commented on BOOKKEEPER-804:
--------------------------------------
Testing JIRA BOOKKEEPER-804
Patch
[0001-BOOKKEEPER-804-Client-program-is-not-terminated-when.patch|https://issues.apache.org/jira/secure/attachment/12683348/0001-BOOKKEEPER-804-Client-program-is-not-terminated-when.patch]
downloaded at Mon Nov 24 17:30:16 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:red}-1 TESTS{color}
. Tests run: 931
. Tests failed: 1
. Tests errors: 1
. The patch failed the following testcases:
. testSimpleChat(org.apache.hedwig.jms.BasicJMSTest)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/851/
> Client program is not terminated when using openLedgerNoRecovery
> ----------------------------------------------------------------
>
> Key: BOOKKEEPER-804
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-804
> Project: Bookkeeper
> Issue Type: Bug
> Components: bookkeeper-client
> Affects Versions: 4.3.0
> Reporter: Youngjoon Kim
> Assignee: Ivan Kelly
> Fix For: 4.4.0, 4.3.1
>
> Attachments:
> 0001-BOOKKEEPER-804-Client-program-is-not-terminated-when.patch,
> 0001-BOOKKEEPER-804-Client-program-is-not-terminated-when.patch
>
>
> If a client program does some operations using a ledger handle opened by
> openLedgerNoRecovery(), the program is not terminated after the handle and
> bookkeeper object is closed.
> Here is a sample code.
> {code}
> import java.util.Enumeration;
> import org.apache.bookkeeper.client.BookKeeper;
> import org.apache.bookkeeper.client.LedgerEntry;
> import org.apache.bookkeeper.client.LedgerHandle;
> public class BkClient {
> public static void main(String[] args) {
> try {
> BookKeeper bk = new BookKeeper("localhost:2181");
> // 9 is a ledger id of an existing ledger
> LedgerHandle lh = bk.openLedgerNoRecovery(9,
> BookKeeper.DigestType.CRC32, "passwd".getBytes());
> Enumeration<LedgerEntry> entries = lh.readEntries(0, 0);
> lh.close();
> bk.close();
> } catch (Exception e) {
> e.printStackTrace();
> }
> }
> }
> {code}
> Thread dump of this program shows that non-daemon thread
> "ZkLedgerManagerScheduler-0" is alive, after bk.close() is called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)