[
https://issues.apache.org/jira/browse/BOOKKEEPER-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225658#comment-14225658
]
Hadoop QA commented on BOOKKEEPER-799:
--------------------------------------
Testing JIRA BOOKKEEPER-799
Patch
[0001-BOOKKEEPER-799-Distribution-schedule-coverage-sets-d.patch|https://issues.apache.org/jira/secure/attachment/12682858/0001-BOOKKEEPER-799-Distribution-schedule-coverage-sets-d.patch]
downloaded at Wed Nov 26 02:55:49 UTC 2014
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
120
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 FINDBUGS{color}
. {color:green}+1{color} the patch does not seem to introduce new Findbugs
warnings
{color:green}+1 TESTS{color}
. Tests run: 931
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/bookkeeper-trunk-precommit-build/855/
> Distribution schedule coverage sets don't take gaps in response lists into
> account when writequorum > ackquorum
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BOOKKEEPER-799
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-799
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.4.0, 4.3.1, 4.2.4
>
> Attachments:
> 0001-BOOKKEEPER-799-Distribution-schedule-coverage-sets-d.patch
>
>
> The algorithm now be used to check if all quorums are being covered when
> sending a read lac or fencing message is broken when writeQuorum >= ackQuorum.
> The purpose of the algorithm is to tell us when we have heard a response from
> enough nodes, that an ack quorum could not possibly have been formed without
> at least one of the nodes that we have heard responses from.
> The current algorithm works when writeQuorum == ackQuorum, as we consider all
> quorums covered if the first |ackQuorum| nodes in the writeQuorum are
> covered. However, this doesn't work in the case that it's the middle node in
> the quorum that we have heard.
> Take the example, e:4, w:3, a:2, and we've heard from node 0, and node 2. In
> this case, it is possible for the write quorum, 1,2,3 to get an ack quorum if
> 1 and 3 response.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
