On 18 October 2014 11:41, Flavio Junqueira <[email protected]> wrote: > I haven't checked the code carefully, but the flow is really good. The > discussion about the ZK leader election is possibly a bit too detailed for a > tutorial on BK, but otherwise it is good, it gives good insight. It might > also be useful as a follow up step to add a discussion on rolling ledgers and > deleting ledgers to reclaim space. There is a bit about it in the end, but > for a tutorial it doesn't hurt to have more detail.
Ya, rolling is needed. I didn't want to put it into the initial sections though, as it makes the code harder to follow, especially if you are learning it. It's like the entryid stuff. It's something very simple, but kludges up the code a lot. I think rolling should possibly be another tutorial entirely, as there's some subtleties around it (like how much to trim?, if there's multiple followers, who should trim?). > > I have pushed a few suggested edits. I made one comment on it. Otherwise it's ready for merge. -Ivan
