On Thu, 2009-05-14 at 11:35 -0400, Stephen Hemminger wrote:
> Unless STP is enabled, br_topology_change is bogus.  It looks like,
> the following would avoid the problem?

Yes, it does and it looks like a much better fix to me. 

Thanks, Ian.

> 
> --- a/net/bridge/br_stp.c     2009-05-14 08:33:01.795909321 -0700
> +++ b/net/bridge/br_stp.c     2009-05-14 08:34:32.839883992 -0700
> @@ -375,7 +375,8 @@ static void br_make_forwarding(struct ne
>  
>       if (br->forward_delay == 0) {
>               p->state = BR_STATE_FORWARDING;
> -             br_topology_change_detection(br);
> +             if (p->br->stp_enable == BR_KERNEL_STP)
> +                     br_topology_change_detection(br);
>               del_timer(&p->forward_delay_timer);
>       }
>       else if (p->br->stp_enabled == BR_KERNEL_STP)
> 
> 

_______________________________________________
Bridge mailing list
[email protected]
https://lists.linux-foundation.org/mailman/listinfo/bridge

Reply via email to