On 2014/12/11 11:13, David Miller wrote: > From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> > Date: Thu, 11 Dec 2014 11:04:44 +0900 > >> On 2014/12/11 4:50, David Miller wrote: >>> From: Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> >>> Date: Wed, 10 Dec 2014 11:43:14 +0900 >>> >>>> - features &= ~NETIF_F_ONE_FOR_ALL; >>>> + features &= ~NETIF_F_ONE_FOR_ALL | NETIF_F_GSO_SOFTWARE; >>> >>> I don't think this is the expression you intend to use. >> >> Thank you, but this is really my intended expression. >> >> "features &= ~NETIF_F_ONE_FOR_ALL" drops all of ONE_FOR_ALL bits >> including GSO_SOFTWARE. >> But I want to leave GSO_SOFTWARE bits here. > > It is clearer to say this as: > > ~(NETIF_F_ONE_FOR_ALL & ~NETIF_F_GSO_SOFTWARE) > > Or create a new NETIF_F_* macro to express this idea succinctly.
OK, I will. (once net-next is reopened) Thanks, Toshiaki Makita
