On Mon, Jun 10, 2019 at 07:41:36PM +0200, Pablo Neira Ayuso wrote: > Thanks for updating this patch to use struct brnf_net. > > A few comments below. > > On Sun, Jun 09, 2019 at 06:23:04PM +0200, Christian Brauner wrote: > [...] > > diff --git a/include/net/netfilter/br_netfilter.h > > b/include/net/netfilter/br_netfilter.h > > index 89808ce293c4..302fcd3aade2 100644 > > --- a/include/net/netfilter/br_netfilter.h > > +++ b/include/net/netfilter/br_netfilter.h > > @@ -85,17 +82,42 @@ static inline __be16 vlan_proto(const struct sk_buff > > *skb) > > return 0; > > } > > > > -#define IS_VLAN_IP(skb) \ > > - (vlan_proto(skb) == htons(ETH_P_IP) && \ > > - brnf_filter_vlan_tagged) > > +static inline bool is_vlan_ip(const struct sk_buff *skb, const struct net > > *net) > > +{ > > I like this conversion from macro to static inline a lot. > > But if you let me ask for one more change, would you split this in two > patches? One to replace #defines by static inline.
Sure.