On 7/24/19 1:54 AM, kbuild test robot wrote: > From: kbuild test robot <[email protected]> > > net/bridge/br_multicast.c:999:8-14: ERROR: application of sizeof to pointer > > sizeof when applied to a pointer typed expression gives the size of > the pointer > > Generated by: scripts/coccinelle/misc/noderef.cocci > > Fixes: 17c91348ed8b ("Use-after-free in br_multicast_rcv") > CC: Nikolay Aleksandrov <[email protected]> > Signed-off-by: kbuild test robot <[email protected]> > --- > > url: > https://github.com/0day-ci/linux/commits/Nikolay-Aleksandrov/net-bridge-mcast-fix-possible-uses-of-stale-pointers/20190702-083354 > > br_multicast.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -996,7 +996,7 @@ static int br_ip6_multicast_mld2_report( > return -EINVAL; > > _nsrcs = skb_header_pointer(skb, nsrcs_offset, > - sizeof(_nsrcs), &__nsrcs); > + sizeof(*_nsrcs), &__nsrcs); > if (!_nsrcs) > return -EINVAL; > >
This must be quite old, I already sent a proper patch without this error. This one was sent just for testing, hence the TEST in $subject. [PATCH TEST] net: bridge: mcast: fix possible uses of stale pointers Thanks, Nik
