On 12.10.2020 00:10, Jakub Kicinski wrote: > On Sun, 11 Oct 2020 21:34:58 +0200 Heiner Kallweit wrote: >> In several places the same code is used to populate rtnl_link_stats64 >> fields with data from pcpu_sw_netstats. Therefore factor out this code >> to a new function dev_fetch_sw_netstats(). > > FWIW probably fine to convert nfp_repr_get_host_stats64() as well, just > take out the drop counter and make it a separate atomic. If you're up > for that. > Looking at nfp_repr_get_host_stats64() I'm not sure why the authors decided to add a 64bit tx drop counter, struct net_device_stats has an unsigned long tx_dropped counter already. And that the number of dropped tx packets exceeds 32bit (on 32bit systems) seems not very likely.
- [Bridge] [PATCH net-next 03/12] net: macsec: use new func... Heiner Kallweit
- [Bridge] [PATCH net-next 09/12] iptunnel: use new functio... Heiner Kallweit
- [Bridge] [PATCH net-next 01/12] net: core: add function d... Heiner Kallweit
- Re: [Bridge] [PATCH net-next 01/12] net: core: add f... Heiner Kallweit
- [Bridge] [PATCH net-next 08/12] net: dsa: use new functio... Heiner Kallweit
- Re: [Bridge] [PATCH net-next 08/12] net: dsa: use ne... Florian Fainelli
- [Bridge] [PATCH net-next 05/12] net: usbnet: use new func... Heiner Kallweit
- [Bridge] [PATCH net-next 11/12] net: openvswitch: use new... Heiner Kallweit
- [Bridge] [PATCH net-next 07/12] net: bridge: use new func... Heiner Kallweit
- [Bridge] [PATCH net-next 12/12] xfrm: use new function de... Heiner Kallweit
- Re: [Bridge] [PATCH net-next 00/12] net: add and use func... Heiner Kallweit
- [Bridge] [PATCH net-next 10/12] mac80211: use new functio... Heiner Kallweit
- [Bridge] [PATCH net-next 04/12] net: usb: qmi_wwan: use n... Heiner Kallweit