On 2/27/24 20:23, Breno Leitao wrote:
If br_multicast_init_stats() fails, there is no need to set lockdep
classes. Just return from the error path.

Signed-off-by: Breno Leitao <[email protected]>
---
  net/bridge/br_device.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c
index 4f636f7b0555..c366ccc8b3db 100644
--- a/net/bridge/br_device.c
+++ b/net/bridge/br_device.c
@@ -135,10 +135,11 @@ static int br_dev_init(struct net_device *dev)
                br_vlan_flush(br);
                br_mdb_hash_fini(br);
                br_fdb_hash_fini(br);
+               return err;
        }
netdev_lockdep_set_classes(dev);
-       return err;
+       return 0;
  }
static void br_dev_uninit(struct net_device *dev)

Please send them as separate patches next time. These are not related and shouldn't be a part of a set.

Acked-by: Nikolay Aleksandrov <[email protected]>

Reply via email to