Re: [PATCH v6 net-next 05/14] bridge: Add filling forward path from port to port

[Eric Woudstra]

On 2/11/25 5:00 PM, Nikolay Aleksandrov wrote:
> On 2/11/25 15:28, Vladimir Oltean wrote:
>> On Sun, Feb 09, 2025 at 12:10:25PM +0100, Eric Woudstra wrote:
>>> @@ -1453,7 +1454,10 @@ void br_vlan_fill_forward_path_pvid(struct 
>>> net_bridge *br,
>>>     if (!br_opt_get(br, BROPT_VLAN_ENABLED))
>>>             return;
>>>  
>>> -   vg = br_vlan_group(br);
>>> +   if (p)
>>> +           vg = nbp_vlan_group(p);
>>> +   else
>>> +           vg = br_vlan_group(br);
>>>  
>>>     if (idx >= 0 &&
>>>         ctx->vlan[idx].proto == br->vlan_proto) {
>>
>> I think the original usage of br_vlan_group() here was incorrect, and so
>> is the new usage of nbp_vlan_group(). They should be br_vlan_group_rcu()
>> and nbp_vlan_group_rcu().
>>
> 
> Oops, right. Nice catch!
> 

Hi Nikolay,

I gather that I can include your Acked-by also in the corrected patch.