This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- selftests: forwarding: bridge_mdb_max: add tests for mdb_n_entries warning This commit adds tests to exercise different ways which used to trigger a warning in the mdb_n_entries counting code. > diff --git a/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh > b/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh > index 3da9d93ab36f..59d2fa3953ea 100755 > --- a/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh > +++ b/tools/testing/selftests/net/forwarding/bridge_mdb_max.sh [ ... ] > @@ -106,6 +105,7 @@ switch_create_8021q() > > switch_create_8021qvs() > { > + log_info "802.1q mcast_vlan_snoopping 1 tests" ^^^^^^^^ There's a typo: 'snoopping' should be 'snooping'. > switch_create_8021q "mcast_vlan_snooping 1" > bridge vlan global set dev br0 vid 10 mcast_igmp_version 3 > bridge vlan global set dev br0 vid 10 mcast_mld_version 2 [ ... ] > @@ -1334,6 +1405,21 @@ test_8021qvs() > switch_destroy > } > > +test_mdb_count_warning() > +{ > + # Tests for mdb_n_count warning Should this comment say 'mdb_n_entries' instead of 'mdb_n_count' to match the terminology used in the commit message? > + > + log_info "MDB count warning tests" > + switch_create_8021q > + setup_wait > + > + test_mdb_count_mcast_vlan_snooping_flush > + test_mdb_count_mcast_snooping_flush > + test_mdb_count_vlan_state_flush > + > + switch_destroy > +} > + [ ... ] -- pw-bot: cr
