From: Yufan Chen <[email protected]> In brport_store(), switch to kstrtoul() so parse failures and range errors return standard errno directly before taking the bridge lock.
This removes a deprecated API and improves error reporting consistency. Signed-off-by: Yufan Chen <[email protected]> --- v3: - Split from mixed series into a dedicated net series. - No functional changes since v2. net/bridge/br_sysfs_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 1f57c36a7..cdecc7d12 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -318,7 +318,6 @@ static ssize_t brport_store(struct kobject *kobj, struct net_bridge_port *p = kobj_to_brport(kobj); ssize_t ret = -EINVAL; unsigned long val; - char *endp; if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN)) return -EPERM; @@ -339,8 +338,8 @@ static ssize_t brport_store(struct kobject *kobj, spin_unlock_bh(&p->br->lock); kfree(buf_copy); } else if (brport_attr->store) { - val = simple_strtoul(buf, &endp, 0); - if (endp == buf) + ret = kstrtoul(buf, 0, &val); + if (ret) goto out_unlock; spin_lock_bh(&p->br->lock); ret = brport_attr->store(p, val); -- 2.47.3
