[ http://issues.apache.org/jira/browse/PB-13?page=all ]

Ate Douma updated PB-13:
------------------------

      Component: struts
    Fix Version: 0.4

James,

I've looked into this a bit and also reviewed the code you wrote for LEP.

I think I can quite easily "fix" this within the Struts Bridge itself, although 
I won't make it as configurable as you did.
I'll stick to filtering out only these three parameters inside 
org.apache.portals.bridges.struts.PortletServletRequestWrapper.

Your solution also filters getParameter(name) and getParameterValues(name) 
which I also won't do.
If you don't *know* these parameters exists, then why/how would you be able to 
retrieve them like that?
So, I will only filter in the getParametersMap and getParameterNames methods.

I've already done most of this, but need some more time for testing. I'll try 
to commit the changes in a few days.

One note: It would be nice if you could specify the concerning component 
(struts in this case) when you enter a new issue ;-)

> Extra parameters injected into portlet request
> ----------------------------------------------
>
>          Key: PB-13
>          URL: http://issues.apache.org/jira/browse/PB-13
>      Project: Portals Bridges
>         Type: Bug
>   Components: struts
>     Reporter: James Schopp
>     Assignee: Ate Douma
>     Priority: Minor
>      Fix For: 0.4

>
> The extra parameters "_spage", "_sorig", and "_kra" get added to the portlet 
> request  For some applications (IBM WebFacing, for example), these 
> un-expected parameters cause issues. Allthough they may be necessary for the 
> Struts bridge, they should be filtered out by the time the request reaches 
> the actual portlet.
> I have solved this by creating a new RequestWrapper that filters these 
> parameters (configurable in portlet.xml). The wrapper is created (and wrapped 
> around the real request) in my ServletContextProvider.
> Ate, this may be something you consider app-specific, but it's pretty 
> configurable, and there is no overhead if you do not configure any parameters 
> to be filtered. So, it's more flexibility, with no drawbacks (and it get's it 
> out of my code and into yours ;-)
> see: http://support.liferay.com/browse/LEP-529
> thanks, james

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to