[
https://issues.apache.org/jira/browse/PB-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463610
]
Christophe Jolif commented on PB-55:
------------------------------------
Oups, indeed I attached a buggy fix :-(
This one:
https://issues.apache.org/jira/secure/attachment/12348658/FacesContextFactoryImpl.java
should be fine.
> FacesContextFactoryImpl.getFacesContext takes a config as first parameter
> instead of a context as specified in JSF spec
> -----------------------------------------------------------------------------------------------------------------------
>
> Key: PB-55
> URL: https://issues.apache.org/jira/browse/PB-55
> Project: Portals Bridges
> Issue Type: Bug
> Components: jsf
> Affects Versions: 1.0
> Reporter: Christophe Jolif
> Priority: Critical
> Attachments: FacesContextFactoryImpl.java,
> FacesContextFactoryImpl.java, FacesContextFactoryImpl.java
>
>
> FacesContextFactoryImpl class that implements the JSF FacesContextFactory
> interface is not respecting the specification of the getFacesContext method.
> Indeed JSF spec says the signature of the method is the following:
> getFacesContext(java.lang.Object context, java.lang.Object request,
> java.lang.Object response, javax.faces.lifecycle.Lifecycle lifecycle)
> So you would expect to pass as the first object the PortletContext object
> (and that's actually what the reference implementation JSF bridge is
> expecting).
> However FacesContextFactoryImpl version is taking as the first parameter a
> PortletConfig instead of a PortletContext.
> This cause third party software to crash.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]