[ 
https://issues.apache.org/jira/browse/PB-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532472
 ] 

Ate Douma commented on PB-73:
-----------------------------

Martin,

I applied your patch and tested it against our  bridges jsf-demo application 
but encountered some problems.
First of all, the new ViewStateManager.restoreViewState method should check 
against a null viewState parameter as with the CalendarPortlet it thew an NPE.
But even after fixing that myself it didn't work: the managed bean 
(CalendarBean) is never invoked on an action.
I don't have time to further investigate this so could you please check this 
and provide a patch which at least works for our simple test portlets?

Regards,

Ate

> Cumulative patch for better storing the ViewRoot, disabling calling 
> restoreState on the ViewRoot, and better 
> SessionMap/RequestParameterMap/ApplicationMap handling in the servlet case
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PB-73
>                 URL: https://issues.apache.org/jira/browse/PB-73
>             Project: Portals Bridges
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 1.0
>            Reporter: Martin Marinschek
>            Assignee: David Sean Taylor
>         Attachments: jsf-portlet-bridge.patch
>
>
> This patch tries to resolve three issues with the current bridge. It has been 
> created by Thomas Spiegl, Bernhard Huemer and me (just to do the honours ;).
> 1) The UIViewRoot is directly put into the session - this doesn't fly if 
> load-balancing is switched on and the session is serialized between servers, 
> as no JSF-component is serializable (instead, it implements state-holder, and 
> one has to call the appropriate methods restoreState/saveState, and 
> additionally save the tree-structure.
> 2) In the FacesPortlet, a superfluous call to restoreState is happening - if 
> the UIViewRoot is properly restored, restoreState should not be called anymore
> 3) the SessionMap/RequestParameterMap etc. will only work if behind a 
> portlet. In some cases, the JSF-app might run both behind a portlet and a 
> servlet
> regards,
> Martin

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to