[
https://issues.apache.org/jira/browse/PB-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12926808#action_12926808
]
Ate Douma commented on PB-109:
------------------------------
Hi Alexey,
The sequence you describe above seems kind of odd.
If indeed you'll "find" a RENDER_CONTEXT as request attribute in 2.2 but not as
session attribute in 2.1, it looks like if between 1 and 2 (action processing
and render processing) request attributes are "shared".
Per the portlet specification these two phases should not "share" request
attributes, or at least the portlet container should make sure these are not
carried over.
In most portlet containers this is done automatically because after a action
processing a (client-side) redirect is executed from action to render phase.
Maybe this is done differently by the eXo portlet container?
Furthermore, (render) request attributes for different portlets should be
"hidden" from each other as well.
Attribute name encoding should not need to be done by the portlet nor (Struts)
bridge itself but take care of by the portlet container, e.g. by the eXo
portlet container.
Anyway, being able to "see" request attributes from a previous request phase or
between requests for different portlets is a violating of the portlet
specification.
The one "quirky" feature of the Struts Bridge is that it, as a Portlet 1.0
based solution, needs the custom
org.apache.portals.bridges.common.ServletContextProvider interface
to access the ServletContext from a Portlet and invoke Struts through it. With
Portlet 2.0 this no longer would be needed but the Struts Bridge hasn't been
adjusted for that.
Maybe the eXo implementation for the ServletContextProvider interface you are
using causes bypassing of normally guarded (like name encoding) usages of
request attributes?
> Problem with the request wrapper (user action is not considered)
> ----------------------------------------------------------------
>
> Key: PB-109
> URL: https://issues.apache.org/jira/browse/PB-109
> Project: Portals Bridges
> Issue Type: Bug
> Components: struts
> Affects Versions: 1.0.4
> Reporter: Ali Hamdi
> Priority: Minor
>
> We found a bug in Struts Portals bridge reported here :
> http://jira.exoplatform.org/browse/PC-512
> The fix done by eXo developer is here :
> http://jira.exoplatform.org/secure/attachment/25968/diff.txt
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
