On Mar 13, 2012, at 12:17 PM, Tom Browder <[email protected]> wrote:

I'm doing some ws cleaning in the ./src/conv/iges directory and, while
looking at matmult.c, I noticed a couple of things:

1. Isn't there a vmath macro that could replace this?
 
Yes and no.  There's not a vmath macro, but a libbn function that should do what is needed there.

+ is the temp mat_t really necessary?

Probably not.  bn_mat_mul() or bn_mat_mul2() probably suffice (see src/libbn/mat.c)

+ isn't the function arg order backwards from the macro conventions?
 
Looks like it, so you'd need to swap all the callers if you switched to a libbn function.

Cheers!
Sean

------------------------------------------------------------------------------
Keep Your Developer Skills Current with LearnDevNow!
The most comprehensive online learning library for Microsoft developers
is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3,
Metro Style Apps, more. Free future releases when you subscribe now!
http://p.sf.net/sfu/learndevnow-d2d
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to