Hi Cliff,
Could you please give more details where the raytracing problems happen? I just
did some test on the geometries in csgbrep.g, and it seems to work well.
The reason why I added this if-logic here is: if m_removeTrimmed is set, the
m_trimmed field of the BVNode will be checked when it's going to be appended as
a child to the parent. If m_trimmed is true, it cannot be a child. But
prepTrim() will make m_trimmed to be true, causing the building process of
surface tree to fail.
So I have to set m_removeTrimmed to false currently to avoid this problem. But
it SHOULD also work when m_removeTrimmed is true.
Cheers!
Wu
------------------ Original ------------------
From: "starseeker"<[email protected]>;
Date: Mon, Jun 24, 2013 09:13 PM
To: "brlcad-commits"<[email protected]>;
Subject: [brlcad-commits] SF.net SVN:
brlcad:[55821]brlcad/trunk/src/libbrep/opennurbs_ext.cpp
Revision: 55821
http://sourceforge.net/p/brlcad/code/55821
Author: starseeker
Date: 2013-06-24 13:13:46 +0000 (Mon, 24 Jun 2013)
Log Message:
-----------
This was causing raytracing problems - will need to examine the logic more
carefully to see what the correct action is here.
Modified Paths:
--------------
brlcad/trunk/src/libbrep/opennurbs_ext.cpp
Modified: brlcad/trunk/src/libbrep/opennurbs_ext.cpp
===================================================================
--- brlcad/trunk/src/libbrep/opennurbs_ext.cpp 2013-06-24 08:39:54 UTC (rev
55820)
+++ brlcad/trunk/src/libbrep/opennurbs_ext.cpp 2013-06-24 13:13:46 UTC (rev
55821)
@@ -930,8 +930,7 @@
ON_3dPoint(max)),
m_face,
u, v);
- if (!m_removeTrimmed)
- node->prepTrims();
+ node->prepTrims();
} else {
node = new BBNode(ctree, ON_BoundingBox(ON_3dPoint(min),------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel
