On Jul 12, 2013, at 4:47 PM, check.nyah wrote: > I am currently studying the brlcad primives so as to be able to write > the routine to extract the matrix transformations on the solid(leaf) > for most of brlcad's primitives; while I am working on combining the > push and xpush routines(which I submitted some patches on sf) I wish > to know whether I am to clean the code to remove all the older version > of the push and xpush together with the regression tests in > (/regress/mged/xpush.mged, /regress/mged_test.sh) if yes?
Short answer is "yes", but read the CHANGES file in the top-level. Long answer is that user-visible changes like this must go through a formal deprecation/removal process. This may be a "minimally impacting" change, but it depends whether this can be described as a regular expression. If it's not minimally impacting, the xpush command will need to display a DEPRECATION warning message and inform users about the new equivalent push option. It should probably do that regardless because it's a very popular command. We have to be careful how to merge/remove features because we don't want to change things up on our users more than is necessary. It means we have to think through the usability before making the change. This changes begs a question of whether it is better for a combined push+xpush command to split multiply referenced members by default (i.e., xpush) and have an option to not split (i.e., push) or the reverse (i.e., you patch) or something else we have not considered? What are the usability use cases and implications? We should think through them. > I have tried to remove all possible calls for xpush(deprecated) in the > source but i still get this every time I run the regression tests. > Need some assistance here on where to look If you grep the entire source tree, I think you'll find additional references to xpush in tclscript files. More specifically, the help system files are what the regression tests uses. The regression test is specifically testing to make sure every command our help system says is available is actually available. It's doing it's job correctly. ;) Cheers! Sean ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ BRL-CAD Developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/brlcad-devel
