On Fri, Feb 7, 2014 at 1:22 PM, Christopher Sean Morrison
<[email protected]> wrote:
> On Feb 7, 2014, at 12:28 PM, Tom Browder wrote:
>
>> Among other things, the literals, whether global or not,
>> need to be defined somewhere, and, IMHO, shouldn't be duplicated.  I
>> can certainly rename them in accordance with convention.
>
> Absolutely.  Rule of Three is good (minimal), DRY is even better (none).  If 
> they span files, a private header file can be added (which consequently 
> resolves their names being inconsistent, don't need to be as private symbols).

Okay, is there an existing private header at global scope (./include)
that is a good candidate to hold them?

> Fewer would be better!  Might want to look at convert.c (the bu_cv_*() 
> functions)
> and/or the 'cv' utility to make sure you don't expand into an area already 
> covered.

Roger.

> In terms of generality, I think it'd help to find a purpose
> that this can use this before going too far.

Agree.

-Tom

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
BRL-CAD Developer mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to