Argh. Yes, I am stupid, it was supposed to be stroull, not strtoll……. bad me.

On Aug 28, 2012, at 6:19 PM, Seth Hall <[email protected]> wrote:

> 
> On Aug 28, 2012, at 10:33 AM, Bernhard Amann <[email protected]> 
> wrote:
> 
>>              // TODO: check if we can use strtoull instead of atol,
>>              // and similarly for {HEX}.
>> -            RET_CONST(new Val(static_cast<unsigned int>(atol(yytext)),
>> +            RET_CONST(new Val(static_cast<bro_uint_t>(strtoll(yytext, 
>> (char**) NULL, 10)),
>>                        TYPE_COUNT))
> 
> I still don't think this is right since we can't type in a full 64bit uint 
> with this, right?
> 
> Also, we should probably remove that comment now that it won't apply anymore.
> 
>  .Seth
> 
> --
> Seth Hall
> International Computer Science Institute
> (Bro) because everyone has a network
> http://www.bro-ids.org/
> 
> 
> _______________________________________________
> bro-dev mailing list
> [email protected]
> http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev


_______________________________________________
bro-dev mailing list
[email protected]
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to