[ 
https://bro-tracker.atlassian.net/browse/BIT-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Seth Hall updated BIT-1134:
---------------------------

    Attachment: signature.asc





I have a slightly different angle on that.  I think it's reasonable to set 
BRO_DNS_FAKE (assuming it works more completely than it currently does) for the 
tests because eventually I don't think that the scripts in policy will be part 
of the base Bro distribution forever and I think it's reasonable to have them 
tested separately and with all the caveats that accompany testing those scripts.

For the moment though, I still think it's reasonable though since our test 
suite shouldn't be relying on external DNS servers returning the same 
information forever.  Perhaps we should come up with more general tests for 
testing that stuff to make sure that external services are still working and 
working like we expect them to.  For example, if Team Cymru changed the output 
of their MHR service it would be nice to have a test that catches that so we 
can update appropriately but is not normally run for the performance testing.

 .Seth

--
Seth Hall
International Computer Science Institute
(Bro) because everyone has a network
http://www.bro.org/



> DNS_Mgr::LookupAddr does not respect DNS_FAKE
> ---------------------------------------------
>
>                 Key: BIT-1134
>                 URL: https://bro-tracker.atlassian.net/browse/BIT-1134
>             Project: Bro Issue Tracker
>          Issue Type: Problem
>          Components: Bro
>    Affects Versions: 2.2
>            Reporter: Justin Azoff
>            Priority: Low
>         Attachments: signature.asc
>
>




--
This message was sent by Atlassian JIRA
(v6.2-OD-09-036#6252)
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev

Reply via email to