[
https://bro-tracker.atlassian.net/browse/BIT-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23302#comment-23302
]
Justin Azoff commented on BIT-1489:
-----------------------------------
Sounds good. I'll give the code another read through tomorrow and get it merged.
as for the possibility of another branch, I think we should look into any place
where things like [0] or [1] appear, and where we have for loops that unpack
tuples. 'for a,b,c in lst' is better than using [0], [1], [2], but then it
makes it hard to add or remove a field without changing multiple things.
> topic/dnthayer/ticket1396
> -------------------------
>
> Key: BIT-1489
> URL: https://bro-tracker.atlassian.net/browse/BIT-1489
> Project: Bro Issue Tracker
> Issue Type: Problem
> Components: BroControl
> Reporter: Daniel Thayer
> Assignee: Justin Azoff
> Fix For: 2.5
>
>
> Branch topic/dnthayer/ticket1396 in the broctl repo was originally intended
> to address BIT-1396 (logs disappearing on broctl restart). Most of the
> commits
> in this branch are aimed at making it easier to diagnose such problems
> in the future. The most user-visible changes are:
> 1) post-terminate will now send an email if it fails to archive any logs,
> 2) post-terminate will now re-try to archive logs that previously failed to
> be archived,
> 3) improvements to some error messages,
> 4) better sanity checking of config values,
> 5) significant improvements to the broctl README
--
This message was sent by Atlassian JIRA
(v7.1.0-OD-02-030#71001)
_______________________________________________
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
