[ https://bro-tracker.atlassian.net/browse/BIT-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=23819#comment-23819 ]
Justin Azoff edited comment on BIT-1521 at 1/13/16 8:59 AM: ------------------------------------------------------------ Hmm, this may be a little harder than I thought. c$service is a set, and bro doesn't have a bif for comparing one set to another set.. i can do it with a loop like this, but is there a better way? {{function intersects(a: set[string], b: set[string]): bool{ for (one in a) { if (one in b) { return T; } } return F; }}} even though c$service is a set, it should only have 1 or 2 strings in it, so it is not a large loop. was (Author: jazoff): Hmm, this may be a little harder than I thought. c$service is a set, and bro doesn't have a bif for comparing one set to another set.. i can do it with a loop like this, but is there a better way? function intersects(a: set[string], b: set[string]): bool{ for (one in a) { if (one in b) { return T; } } return F; } even though c$service is a set, it should only have 1 or 2 strings in it, so it is not a large loop. > known services should probably ignore gridftp-data > -------------------------------------------------- > > Key: BIT-1521 > URL: https://bro-tracker.atlassian.net/browse/BIT-1521 > Project: Bro Issue Tracker > Issue Type: Improvement > Components: Bro > Affects Versions: 2.4 > Reporter: Justin Azoff > Assignee: Justin Azoff > Priority: Low > > known services script does > {code} > if ( ! addr_matches_host(id$resp_h, service_tracking) || > "ftp-data" in c$service || # don't include ftp data sessions > ("DNS" in c$service && c$resp$size == 0) ) # for dns, require > that the server talks. > return; > {code} > but should probably also ignore gridftp-data. Probably a good idea to add a > set of services that behave like ftp for it to check. -- This message was sent by Atlassian JIRA (v7.1.0-OD-04-012#71001) _______________________________________________ bro-dev mailing list bro-dev@bro.org http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev