> BTW... this does mean that SMB is now in master. :) >
Cool. :) How much of a performance impact would you expect? I'm seeing these runtime increases (with a debug version): [ 50%] tests.short ... failed (+12.0%) [ 75%] tests.medium ... failed (+1.7%) [ 28%] tests.m57-short ... failed (+2.7%) [ 85%] tests.m57-long ... failed (+1.6%) That may be reasonable, but I wanted check what you'd expect. (The tests.short number doesn't bother me too much, that one can go up and down pretty easily I have noticed). I'm also seeing one test failure, see below. Robin [ 0%] coverage.bare-mode-errors ... failed % 'btest-diff errors' failed unexpectedly (exit code 1) % cat .diag == File =============================== error in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/main.bro, line 49: "redef" used but not previously defined (DPD::ignore_violations) internal warning in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/main.bro, line 49: Can't document redef of DPD::ignore_violations, identifier lookup failed error in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/./main.bro, line 49: "redef" used but not previously defined (DPD::ignore_violations) internal warning in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/./main.bro, line 49: Can't document redef of DPD::ignore_violations, identifier lookup failed == Diff =============================== --- /tmp/test-diff.63086.errors.baseline.tmp 2016-08-08 23:07:43.089330553 +0000 +++ /tmp/test-diff.63086.errors.tmp 2016-08-08 23:07:43.103330433 +0000 @@ -0,0 +1,4 @@ +error in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/main.bro, line 49: "redef" used but not previously defined (DPD::ignore_violations) +internal warning in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/main.bro, line 49: Can't document redef of DPD::ignore_violations, identifier lookup failed +error in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/./main.bro, line 49: "redef" used but not previously defined (DPD::ignore_violations) +internal warning in /home/robin/bro/master/testing/btest/../../scripts/base/protocols/ntlm/./main.bro, line 49: Can't document redef of DPD::ignore_violations, identifier lookup failed ======================================= Robin -- Robin Sommer * ICSI/LBNL * [email protected] * www.icir.org/robin _______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
