Thanks, does look like these wouldn't work as intended for CMake < 3.3, but I've merged Daniel's patch in to master now.
- Jon On Thu, Aug 23, 2018 at 3:36 PM Michael Dopheide <[email protected]> wrote: > > Yeah, I just figured that out myself and rebuilt... > > bro -e "print lookup_location(8.8.8.8);" > [country_code=US, region=<uninitialized>, city=<uninitialized>, > latitude=37.751, longitude=-97.822] > > Looks like you'll have the same issue with LibKRB5_FOUND (I didn't look for > others). > > -Dop > > On Thu, Aug 23, 2018 at 3:10 PM, Thayer, Daniel N <[email protected]> > wrote: >> >> Could you try the following patch and let me know if it works for you: >> >> --- a/CMakeLists.txt >> +++ b/CMakeLists.txt >> @@ -134,7 +134,7 @@ include_directories(BEFORE >> >> set(USE_GEOIP false) >> find_package(LibMMDB) >> -if (LibMMDB_FOUND) >> +if (LIBMMDB_FOUND) >> set(USE_GEOIP true) >> include_directories(BEFORE ${LibMMDB_INCLUDE_DIR}) >> list(APPEND OPTLIBS ${LibMMDB_LIBRARY}) >> >> >> ---------------------------------------------------------- >> >> From: [email protected] [[email protected]] on behalf of Michael >> Dopheide [[email protected]] >> >> Sent: Thursday, August 23, 2018 2:16 PM >> >> To: <[email protected]> >> >> Subject: [Bro-Dev] libmaxminddb configure issue >> >> >> >> >> >> >> >> >> >> Johanna mentioned to me that libmaxminddb should be working now in master... >> >> >> >> >> >> So far I haven't been able to get 'configure' to find it, neither with the >> OS packages nor by installing libmaxminddb in /usr/local/ and specifying >> --with-geoip. >> >> >> >> >> >> This is CentOS 7.5. >> >> >> >> >> >> -Dop >> >> >> >> >> >> >> > > _______________________________________________ > bro-dev mailing list > [email protected] > http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev _______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
