Just for anyone who wanted some closure on this, I've submitted the PR: https://github.com/bro/bro/pull/191
On Mon, Oct 15, 2018 at 10:21 PM Vlad Grigorescu <[email protected]> wrote: > Sure, I'll do that. > On Mon, Oct 15, 2018 at 16:19 Jon Siwek <[email protected]> wrote: > >> On Mon, Oct 15, 2018 at 3:33 PM Vlad Grigorescu <[email protected]> wrote: >> >> > The SSH Capabilities record has the following field, which is being set >> incorrectly: >> > >> >> ## Are these the capabilities of the server? >> >> is_server: bool; >> > >> >> result->Assign(6, new Val(${msg.is_orig}, TYPE_BOOL)); >> > >> > Obviously, I'd like to fix this. I'm curious to hear thoughts about >> getting this into 2.6. >> >> Yes, that seems like a bug fix that can be included in 2.6. Do you >> want to make a PR for that and verify/update any unit test baselines >> that change? >> >> - Jon >> >
_______________________________________________ bro-dev mailing list [email protected] http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
