On Tue, 17 Mar 2026 16:48:14 GMT, Thomas Stuefe <[email protected]> wrote:
>> This basically allows configure to complete and set up a configuration
>> suitable for building the BSD port for supported platforms (FreeBSD, OpenBSD
>> and NetBSD.)
>>
>> The flag `_BSDONLY_SOURCE` is defined for all the BSD's _except_ for Apple
>> MacOS, while the existing `_ALLBSD_SOURCE` _includes_ Apple MacOS.
>>
>> For the BSD's we set the `OPENJDK_TARGET_OS_ENV` variable to distinct values
>> reflecting the BSD variant being built. This is used to distinguish build
>> flags, library locations and what libraries and modules to include for the
>> various builds.
>>
>> As an example, FreeBSD includes the ALSA library, and should build the
>> Serviceability Agent, while the other BSD's do not.
>>
>> This work was sponsored by: The FreeBSD Foundation
>
> make/autoconf/platform.m4 line 498:
>
>> 496: if test "x$OPENJDK_$1_OS" = xbsd -o "x$OPENJDK_$1_OS" = xlinux \
>> 497: && test "x$OPENJDK_$1_CPU" = xx86; then
>> 498: # On linux and BSD only, we replace x86 with i386.
>
> Small nit, I had to read twice to see this is correct. Maybe a `{ [ "x$OS" =
> "xbsd" ] || [ "$OS" = "xlinux" ]; } && [ "x$CPU" = "xx86" ];` would be
> clearer. Up to you.
Also, is 32-bit a strong use case for BSD? Since 32-bit support will probably
be removed at some point.
-------------
PR Review Comment:
https://git.openjdk.org/bsd-port/pull/4#discussion_r2948186692
