Hi Sanjiva,
> Hmmm. Does this mean that if commons logging is not there log messages
> will silently disappear? I guess that's ok .. if something really goes
> wrong an exception will come out anyway (BSF is not a server!).
>   
No, the problem was that BSF would not run at all, if commons-logging
was not available to it! Rather an exception (class not found) was
thrown. The present solution (which I already checked-in but which can
be removed or changed easily) tries to resemble the commons-logging
classes LogFactory (with the two constructors) and Log (implementing all
the methods defined in the Log interface). This way the methods of
commons-logging are available to log information, and are forwarded to a
commons-logging Log instance,  if commons-logging is available,
otherwise nothing happens. The "BSF_Log" is a sort of NOP
(null-operation) logger.

> So, +1 to the fix except for calling the classes BSFLogFactory and BSFLog :).
>   
Any other names would be fine, please suggest replacement names (the
intent was to let commons-logging users understand right away the
purpose and role of these two classes, if they wish to employ it for
themselves).

Regards,

---rony


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to