Hi Sanka,

*great* patch!

Did look over it and saw that you have tackled also all other signature
deviations such that now BSF3 should be fully JSR-223/1.6 compliant!

After you check in the changes, we should start to contemplate to create
a beta 2 version of BSF3, what do you (and others on this list) think?

Regards,

---rony




Sanka Samaranayake (JIRA) wrote:
>      [ 
> https://issues.apache.org/jira/browse/BSF-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>  ]
>
> Sanka Samaranayake updated BSF-3:
> ---------------------------------
>
>     Attachment: BSF-3_patch.txt
>
> This patch contains a fix for the described issue. Will apply the patch 
> shortly.
>
>   
>> ScriptEngineManager.getFactories() NOT compliant with JSR223 API
>> ----------------------------------------------------------------
>>
>>                 Key: BSF-3
>>                 URL: https://issues.apache.org/jira/browse/BSF-3
>>             Project: BSF
>>          Issue Type: Bug
>>    Affects Versions: BSF-3.0
>>         Environment: Windows XP, Java 6
>>            Reporter: Ivan Martinez-Ortiz
>>            Priority: Blocker
>>         Attachments: BSF-3_patch.txt
>>
>>
>> Method ScriptEngineManager.getFactories() (trunk code and 
>> tags/bsf-3.0-beta1/ code) returns an array of ScriptEngineFactory. However 
>> JSR 223 Scripting for the Java™ Platform Final Draft Specification version 
>> 1.0 (section SCR.4.3.8.1 Discovery Mechanism, page 168) says that should 
>> return List<ScriptEngineFactory>.
>> Particularly this issue makes impossible develop client code using 
>> bsf3.0-beta1 maintaining the compatibility with Java 6 Scripting API 
>> reference implementation
>>     
>
>   

Reply via email to